libbpf: move arena variables out of the zero page #10319
Closed
+261
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 4722981 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
4a6b8b7 to
1efb39d
Compare
Author
|
Upstream branch: 7dc211c |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
66bc771 to
af1e7a8
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
1efb39d to
5b97b4a
Compare
Author
|
Upstream branch: ec12ab2 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
af1e7a8 to
45dd3f1
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5b97b4a to
7b6b51d
Compare
Author
|
Upstream branch: d6ec090 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
45dd3f1 to
42f87c7
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7b6b51d to
2412df8
Compare
Author
|
Upstream branch: d6ec090 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
42f87c7 to
04480e6
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2412df8 to
bfb0726
Compare
Author
|
Upstream branch: d088da9 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
04480e6 to
55f3e2d
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
bfb0726 to
b0a5b86
Compare
Author
|
Upstream branch: e0940c6 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
55f3e2d to
69324ab
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b0a5b86 to
44cbecf
Compare
Author
|
Upstream branch: 4dd3a48 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
5495939 to
7eff153
Compare
Author
|
Upstream branch: 4dd3a48 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
7eff153 to
2e148d3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
ca453f8 to
b3f74e5
Compare
Author
|
Upstream branch: 8f7cf30 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
2e148d3 to
2ddc373
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b3f74e5 to
b57110f
Compare
Author
|
Upstream branch: c427320 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
2ddc373 to
8efbd4b
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b57110f to
8af6f05
Compare
Author
|
Upstream branch: fad8040 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
8efbd4b to
03424fd
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
8af6f05 to
1ef1ad2
Compare
Author
|
Upstream branch: acf8726 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
03424fd to
7c5213e
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
1ef1ad2 to
58a99d6
Compare
Author
|
Upstream branch: 4617b30 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
7c5213e to
624f01c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
58a99d6 to
d52edef
Compare
The big_alloc1 test in verifier_arena_large assumes that the arena base and the first page allocated by bpf_arena_alloc_pages are identical. This is not the case, because the first page in the arena is populated by global arena data. The test still passes because the code makes the tacit assumption that the first page is on offset PAGE_SIZE instead of 0. Make this distinction explicit in the code, and adjust the page offsets requested during the test to count from the beginning of the arena instead of using the address of the first allocated page. Signed-off-by: Emil Tsalapatis <[email protected]> Reviewed-by: Eduard Zingerman <[email protected]>
Add a stub function for reporting in which offset within a mapping libbpf places the map's data. This will be used in a subsequent patch to support offsetting arena variables within the mapped region. Adjust skeleton generation to account for the new arena memory layout by adding padding corresponding to the offset into the arena map. Add a libbbpf API function to get the data offset within the map's mapping during skeleton generation. Signed-off-by: Emil Tsalapatis <[email protected]>
Currently, libbpf places global arena data at the very beginning of the arena mapping. Stray NULL dereferences into the arena then find valid data and lead to silent corruption instead of causing an arena page fault. The data is placed in the mapping at load time, preventing us from reserving the region using bpf_arena_reserve_pages(). Adjust the arena logic to attempt placing the data from an offset within the arena (currently 16 pages in) instead of the very beginning. If placing the data at an offset would lead to an allocation failure due to global data being as large as the entire arena, progressively reduce the offset down to 0 until placement succeeds. Adjust existing arena tests in the same commit to account for the new global data offset. New tests that explicitly consider the new feature are introduced in the next patch. Signed-off-by: Emil Tsalapatis <[email protected]>
Author
|
Upstream branch: 590699d |
Add tests for the new libbpf globals arena offset logic. The tests cover all three cases: The globals being small enough to be placed at the maximum possible offset, being as large as the arena itself and being placed at the very beginning, and requiring an intermediate offset into the arena. Signed-off-by: Emil Tsalapatis <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1024622=>bpf-next
branch
from
624f01c to
79adece
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1024622 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: move arena variables out of the zero page
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1024622