Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated _trades dataframe with 1D Indicator variables for Entry and E… #1116

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

lachyn21
Copy link
Contributor

@lachyn21 lachyn21 commented Feb 12, 2024

…xit bars

Fixes #1033

@kernc kernc force-pushed the master branch 5 times, most recently from 428c361 to 0ce6cab Compare January 21, 2025 07:25
@kernc kernc self-assigned this Jan 22, 2025
@kernc kernc force-pushed the my-techdoc-contribution branch from 3c45789 to 3461dcf Compare January 22, 2025 04:08
@kernc kernc merged commit 4b829b7 into kernc:master Jan 22, 2025
4 checks passed
mmortall pushed a commit to mmortall/backtesting-ext.py that referenced this pull request Feb 3, 2025
* Updated _trades dataframe with 1D Indicator variables for Entry and Exit bars

* Shorter form, vectorized over index

* Remove Strategy.get_indicators_dataframe() public helper method

* Account for multi-dim indicators and/or no trades

---------

Co-authored-by: kernc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question - add columns to output of bt.run()
2 participants