fix(store): report non-object inputSchema and surface schema findings - #215
Merged
Merged
Conversation
- Detect nonObjectRoot on inputSchema and warn on tools/list frames - Record nonDefaultDialect on inputSchema and outputSchema as observation - Surface all schema findings in check, export, and optional --fail-on schema - Include findings in per-tool JSON/text/HTML export output Fixes kerlenton#199
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect and report tool
inputSchemavalues that are not valid object schemas (per MCP spec), record non-default JSON Schema dialects as observations, and surface all schema findings throughcheck,export, and an opt-in--fail-on schemasignal.Motivation
Fixes #199 — servers like
@modelcontextprotocol/server-filesystemcan advertise tools whoseinputSchemais only{"":"..."}with notype: object. SDKs reject these silently, butmcpsnoop checkpreviously passed with zero warnings. Schema composition findings (oneOf, etc.) were computed but only shown in the TUI.Changes
nonObjectRootfinding for absent/invalid inputSchema roots; warn on thetools/listresponse framenonDefaultDialectobservation for non-2020-12$schemaon inputSchema and outputSchemaFindingsschema findings:section inchecktext output; addschemato--fail-onfindingsin JSON/text/HTML exportnonObjectRootfirst in TUI schema headline orderTests
All pass. Full suite except two pre-existing TUI style tests on upstream main (
TestStreamRowShowsSupersededStatusInWarnStyle,TestStatusStyleWarnsOnTruncated).Notes
nonObjectRootfails defaultcheckvia the existingwarnsignal (warning on frame)--fail-on schemato fail CI