Fix ice candidate gather and extended candidate buffer

[cedricve]

Description

Pull Request Description: Fix Ice Candidate Gather and Extend Candidate Buffer

Motivation

The current implementation of the WebRTC connection in our project has shown inefficiencies and potential issues related to ICE candidate gathering and processing. Specifically, the existing unbuffered channels for ICE candidates can lead to blocking and delays, negatively impacting the connection setup process. Additionally, some redundant code and potential memory leaks have been identified, which need to be addressed to improve the stability and performance of the WebRTC connections.

Changes and Improvements

1. Buffered ICE Candidate Channels:

   • Changed the ICE candidate channels to be buffered with a size of 100. This prevents blocking when candidates are being gathered and sent, allowing for smoother and faster connection setup.

   CandidateArrays[key] = make(chan string, 100)
   CandidateArrays[sessionKey] = make(chan string, 100)

2. Improved ICE Candidate Handling:

   • Moved the candidate processing loop into a separate goroutine to ensure non-blocking behavior and continuous processing of incoming candidates.

   go func() {
       for candidate := range CandidateArrays[sessionKey] {
           CandidatesMutex.Lock()
           log.Log.Info("Received candidate from channel: " + candidate)
           if candidateErr := peerConnection.AddICECandidate(pionWebRTC.ICECandidateInit{Candidate: string(candidate)}); candidateErr != nil {
               log.Log.Error("Error adding candidate: " + candidateErr.Error())
           }
           CandidatesMutex.Unlock()
       }
   }()

3. Connection Cleanup Enhancements:

   • Added deletion of peer connections from the map upon closure to prevent potential memory leaks and ensure proper cleanup.

   delete(peerConnections, handshake.SessionID)

4. Code Cleanup:

   • Removed commented out and redundant code to enhance code readability and maintainability.
   • Removed unnecessary loop closing peer connections in WriteToTrack function, ensuring proper resource management.

Why It Improves the Project

• Enhanced Performance: By using buffered channels and separating candidate processing into a goroutine, the changes ensure that ICE candidates are handled more efficiently, reducing connection setup times and avoiding potential blocking issues.
• Improved Stability: Proper cleanup of peer connections and deletion from the map helps prevent memory leaks and ensures that resources are managed correctly, leading to a more stable application.
• Code Quality: Removing redundant and commented-out code improves the readability and maintainability of the codebase, making it easier for future development and debugging.

Overall, these changes aim to enhance the performance, stability, and maintainability of the WebRTC connection handling in our project.