Correct peerconnection states + proper cleanup peerconnection

[cedricve]

Description

Pull Request: Correct peerconnection states + proper cleanup peerconnection

Motivation

The primary motivation behind this pull request is to improve the robustness and reliability of the WebRTC peer connection handling within our project. By ensuring that the peer connection states are correctly managed and that resources are properly cleaned up, we can prevent potential memory leaks and improve the overall stability of the application.

Changes Made

1. Corrected Peer Connection State Handling:

   • Replaced OnICEConnectionStateChange with OnConnectionStateChange to handle peer connection states more accurately.
   • Adjusted the handling of different peer connection states (Disconnected, Closed, Connected, Connecting, and Failed) to ensure appropriate actions are taken for each state.

2. Proper Cleanup of Peer Connections:

   • Added logic to correctly manage and delete entries from the CandidateArrays map when the peer connection is closed or disconnected.
   • Ensured that locks (CandidatesMutex) are correctly used to prevent race conditions during state changes and cleanup.
   • Removed unnecessary channels (e.g., PacketsCount) that were not being used effectively.

3. Improved Resource Management:

   • Ensured that the peerConnection.Close() method is called appropriately to release resources.
   • Added checks to avoid redundant operations when the peer connection is already in a connected state.

Benefits

• Increased Stability: By correctly managing peer connection states and ensuring proper cleanup, we reduce the risk of memory leaks and other stability issues.
• Improved Performance: Proper resource management ensures that the system does not hold onto unnecessary resources, improving overall performance.
• Enhanced Reliability: Accurate handling of peer connection states ensures that the application behaves predictably under various network conditions.

Overall, these changes contribute to a more robust and maintainable WebRTC implementation in our project, enhancing the user experience and reliability of the application.