fix / revert to old webrtc sample format (duration instead of packettimestamp) #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull Request Description: fix / revert to old webrtc sample format (duration instead of packettimestamp)
Motivation
The recent updates to the WebRTC sample format, which included the use of
PacketTimestamp
instead ofDuration
, have introduced compatibility issues and unexpected behavior in our media streaming functionality. This pull request aims to revert to the previous sample format usingDuration
, ensuring stability and consistency in our WebRTC implementation.Changes
Revert PacketTimestamp to Duration:
bufferDuration
for both video and audio packets.PacketTimestamp
withDuration
in thepionMedia.Sample
struct.Code Cleanup:
PacketTimestamp
related code for clarity.Why This Improves the Project
Duration
field.Duration
has been tested and proven to work reliably. This change minimizes the risk of introducing new bugs related to timestamp handling.By reverting to the old WebRTC sample format, we ensure a more stable and reliable media streaming experience for our users.