Refactor: Use embedding.EmbeddingVariables in Keras-RS JAX embedding tests.

[adityagupta1089]

This change updates the Keras-RS JAX embedding tests to use the embedding.EmbeddingVariables dataclass from jax_tpu_embedding for representing embedding tables and slot variables, instead of a custom tuple structure. This involves updating type hints, variable access, and build dependencies.

[gemini-code-assist]

Summary of Changes

Hello @adityagupta1089, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Keras-RS JAX embedding tests to standardize the representation of embedding tables and slot variables. Instead of using custom tuple structures, the tests now leverage the embedding.EmbeddingVariables dataclass from jax_tpu_embedding. This change improves code clarity, maintainability, and consistency by adopting a more structured and official data representation, making the codebase easier to understand and extend.

Highlights

• Refactored Embedding Variable Representation: The custom tuple structure previously used for representing embedding tables and slot variables in JAX tests has been replaced with the more structured embedding.EmbeddingVariables dataclass from jax_tpu_embedding.
• Updated Type Hints: All relevant type hints across the affected files have been updated to reflect the use of the embedding.EmbeddingVariables dataclass, improving type safety and code clarity.
• Modified Variable Access: Access to embedding tables and slot variables has been changed from tuple indexing (e.g., table_and_slot_variables[0]) to attribute access (e.g., table_and_slot_variables.table), aligning with the dataclass structure.
• Dependency Update: The embedding module from jax_tpu_embedding.sparsecore.lib.nn has been imported to support the new dataclass usage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the JAX embedding tests to use the embedding.EmbeddingVariables dataclass instead of tuples for representing embedding tables and slot variables. The changes are consistent with the goal of improving code clarity and maintainability by using a more explicit data structure. The type hints and variable access patterns have been updated accordingly across the test files.

My review includes one suggestion to further improve type safety in a test utility function by using a TypeVar instead of Any, which would make the code even more robust and easier to understand.

[hertschuh]

Please run ruff --config pyproject.toml format . to fix the code format.

[hertschuh]

Thanks for the PR!