-
Couldn't load subscription status.
- Fork 2.1k
Cleanup templates/ dir #2205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cleanup templates/ dir #2205
Conversation
Summary of ChangesHello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a comprehensive update and expansion of the examples and tutorials, primarily driven by running the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a comprehensive update to the documentation and example files. The changes include removing verbose output from notebooks, fixing typos, adding necessary installation commands, and performing minor but important code refactoring and bug fixes. A new set of tutorials for DistributedEmbedding on JAX and TensorFlow has also been added. Overall, these changes significantly improve the clarity, correctness, and usability of the examples. I've found one minor issue with a leftover terminal artifact in one of the markdown files.
|
What about the |
|
Noticed that these .md files are actually present in https://github.com/keras-team/keras-io/tree/master/examples/keras_rs, why do we have these again in templates directory? |
|
This is the PR which caused this #2083 |
|
This was an accident, the files in the |
|
Got it, deleted the files under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup! This was confusing.
Ran the
python autogen.py makecommand and noticed many of the tutorials and examples having outdated examples/not synced or having extra length output for epochs.