Adds new landing page and updates internal page styling#2055
Adds new landing page and updates internal page styling#2055alexabbott wants to merge 27 commits intokeras-team:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
feat: docs - more css updates
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
Most of the comments are on that tracking sheet, but adding some comments here that are more code specific as well!
| templates/keras_tuner/getting_started.md | ||
| datasets/* | ||
| .vscode/* No newline at end of file | ||
| .vscode/* |
There was a problem hiding this comment.
I don't think you need all this. Maybe just ignore .idea/?
There was a problem hiding this comment.
Remove all these .idea files form the PR (just don't commit them).
| /* Text Colors */ | ||
| --text-black: #292321; | ||
| --text-red: #A30000; | ||
| } No newline at end of file |
There was a problem hiding this comment.
lots of missing newlines at end of files.
| mobileNavSearchForm.style.display = 'none'; | ||
| }); | ||
|
|
||
| // Parallax functionality |
There was a problem hiding this comment.
I wonder if this whole code block would be less jerky if you dynamically updated the element css to switch between position fixed and relative--so the render engine will keep fixed rather than trying to dynamically set a height in js. Not a web dev expert though!
| </button> | ||
| <pre> | ||
| <code class="language-python"> | ||
| inputs = keras.Input(shape=(32, 32, 3)) |
There was a problem hiding this comment.
We should remove the tab from these pre blocks so they copy without extra spaces. Instead just style the code card padding to get whatever left alignment we want.
fix: docs styling - addressing QA feedback
fix: landing page - sticky textbox section fix
6 participants
This pull request revises the landing page code to align with new designs.
This pull request also updates the internal pages to ensure consistent navigation and styling with the landing page.