Correct minor issue in the guide "Understanding masking & padding"#1904
Correct minor issue in the guide "Understanding masking & padding"#1904palc001 wants to merge 2 commits intokeras-team:masterfrom
Conversation
Correct the axis for computing the denominator of softmax in the example which creates a `TemporalSoftmax` class.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Correct the axis for computing the denominator of softmax in the example which creates a `TemporalSoftmax` class.
|
@fchollet As per my understanding, a softmax over the time dimension (axis 1) of an input sequence implies that the softmax should be applied along the sequence length dimension individually over each embedding dimension. To illustrate with a better example: With my suggested correction to Edit: Also saw from |
Correct the axis for computing the denominator of softmax in the example which creates a
TemporalSoftmaxclass.