Skip to content

Conversation

harshaljanjani
Copy link
Collaborator

@harshaljanjani harshaljanjani commented Sep 24, 2025

Description of the change

Update Moonshine to support the JAX backend in the keras-nightly version.
The T5 fix is more involved; adding the compute_output_shape() method cascades into quantized model build issues. I currently don’t have the bandwidth to address this involved fix.
Feel free to merge this and handle T5 later though!

cc: @divyashreepathihalli @mattdangerw

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

Copy link

Summary of Changes

Hello @harshaljanjani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enabling the Moonshine model to function correctly with the JAX backend in the keras-nightly environment. The core change involves adding explicit output shape computation for a key internal layer, which is essential for JAX's static graph compilation. This enhancement broadens the compatibility of Moonshine models, though a known, more complex issue related to T5 models is acknowledged and set aside for future work.

Highlights

  • JAX Backend Support: The Moonshine model now officially supports the JAX backend when used with keras-nightly.
  • Shape Inference Fix: The PositionEmbedding layer within MoonshineBackbone has been updated with a compute_output_shape method to ensure correct shape inference, which is crucial for JAX compatibility.
  • T5 Model Deferral: A more involved fix for T5 models, which would address quantized model build issues, has been explicitly deferred to a later pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@harshaljanjani harshaljanjani self-assigned this Sep 24, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the compute_output_shape method to the Arange layer, which is a necessary update for JAX backend support in keras-nightly. The change is sound. I have provided one review comment suggesting further improvements to the Arange layer to fully align it with the project's style guide for custom layers. This includes adding a docstring, __init__, and get_config method to enhance maintainability and ensure proper serialization.

@harshaljanjani harshaljanjani added the kokoro:force-run Runs Tests on GPU label Sep 24, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants