-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to rely on GCB from GitHub actions #782
Conversation
/gcbrun |
1 similar comment
/gcbrun |
56b15d4
to
ca7783d
Compare
/gcbrun |
We could still use Action well known syntax but using GCP resources https://github.com/terraform-google-modules/terraform-google-github-actions-runners |
As a side note switching to the cloudbuild syntax will make contributing or co-maintaining the CI with the community harder. (Just extending or make a change in the CI it will be not testable anymore locally or in a fork). |
See also tensorflow/build#61 (comment) |
Good point, yeah this would make it much harder for community members to update it. Ideally we could still use GH-actions, so maybe self hosted is the best option. |
As of now though… the repo is fully blocked by failing unit tests |
Generally models tests are quite heavy and I don't think that we could accumulate models and run these tests on every PR. It could be ok on the PR to check the specific model when we modify a specific network and probably test all models before the nightly cut (if we can scale). In any case I think that currently the main problem with the free hosted Action is that this test is exhausting 7GB max ram in the runner (Github free tier): |
If the build is failing due to heavy ram consumption, how about config some of the test to be integration test and not run them in the unit test suite? Since the code base is expending, we should find a more scalable solution (probably discuss in the team meeting). For now, let's run the GPU test which should have the same test coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check with the team before submission.
Sounds good, I also like @bhack ’s idea to disable model tests on GitHub actions and only run those before cuts |
we unfortunately have hit the point where we cannot keep using GitHub actions due to scaling concerns. GCB allows us to configure out own CI cluster and timeouts - as such we will need to rely on that going forward.