Fixed: #1722 Run out of memory #1724
Conversation
Update utils.py and test by using `break` instead of `raise`
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 3411 3413 +2
=========================================
+ Hits 3411 3413 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for the fix!
If history is None, it should trigger this error. To your test, does it trigger it?
We can first add a if to check its None, return an empty dict.
Check for empty dict in Oracle.update_trial to return invalid status.
I can make the change if you prefer?
Will be the changes small, then I would prefer if you would do it because I have to first get into the code. Otherwise, I will take later a look. |
|
@Anselmoo I will make the fix then, it may take some time. Thanks. |
|
This is blocked by: |
| if batch_size == 1: | ||
| raise e | ||
| print( |
There was a problem hiding this comment.
I am not sure if using print a right approach here?
Update utils.py and test by using
breakinstead ofraiseWhich issue(s) does this Pull Request fix?
resolves #1722
Details of the Pull Request
According to discussion #1721, the
raisewill be replaced bybreakfor running out of memory in the case ofbatch_size==1.