Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): introduce insecureSkipTlsVerify parameter #3711

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Aug 27, 2024

Fixes: #3678

Follow up

#3712

Changes

  • introduced new parameter to skip tls certificate verification
  • adapted interfaces and functions to use this parameter

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.72%. Comparing base (df11440) to head (b92da85).
Report is 1 commits behind head on main.

Files Patch % Lines
...ollers/common/providers/dynatrace/dynatrace_dql.go 75.00% 3 Missing ⚠️
...erator/controllers/analysis/fake/evaluator_mock.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
+ Coverage   74.68%   74.72%   +0.04%     
==========================================
  Files         225      225              
  Lines       10132    10160      +28     
==========================================
+ Hits         7567     7592      +25     
- Misses       2195     2198       +3     
  Partials      370      370              
Files Coverage Δ
...rics-operator/api/v1/keptnmetricsprovider_types.go 66.66% <ø> (ø)
...rator/controllers/analysis/objectives_evaluator.go 78.94% <100.00%> (ø)
...operator/controllers/analysis/provider_selector.go 88.31% <100.00%> (+0.64%) ⬆️
...-operator/controllers/common/providers/provider.go 100.00% <100.00%> (ø)
metrics-operator/controllers/metrics/controller.go 80.16% <100.00%> (ø)
...erator/controllers/analysis/fake/evaluator_mock.go 54.16% <80.00%> (ø)
...ollers/common/providers/dynatrace/dynatrace_dql.go 85.16% <75.00%> (-0.70%) ⬇️
Flag Coverage Δ
certificate-operator 47.20% <ø> (ø)
component-tests 58.04% <ø> (ø)
lifecycle-operator 76.24% <ø> (ø)
metrics-operator 76.30% <92.98%> (+0.12%) ⬆️
scheduler 34.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 27, 2024
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review August 27, 2024 08:02
@odubajDT odubajDT requested review from a team as code owners August 27, 2024 08:02
@mowies mowies changed the title feat(metrics-operator): introduce SkipVerifyCertificate parameter feat(metrics-operator): introduce insecureSkipTlsVerify parameter Aug 27, 2024
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to also copy over the new CRD definitions to the helm chart?

metrics-operator/api/v1/keptnmetricsprovider_types.go Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@github-actions github-actions bot added the ops label Aug 27, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

@odubajDT odubajDT merged commit c51c5e4 into keptn:main Aug 27, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator ops
Projects
None yet
3 participants