KEP 89: Lifecycle Toolkit - Context Information in Keptn Tasks

[thschue]

Signed-off-by: Thomas Schuetz [email protected]

[thisthat]

I have mixed feelings for this KEP. On one hand, I see the benefits of giving the tasks as much information as they need. Whenever we add extra info to our CRDs (e.g., KEP88), they get it for free without code change. On the other hand, tasks need to parse the JSON which require them to be aware of the version of App and Workload. Furthermore, as highlighted in the drawback section, there might be severe security issue in the future.

[thisthat]

I would follow RFC2119 and have extra emphasis on this requirement

Suggested change

	* There is no sensitive information in the context information
	* There MUST NOT be sensitive information in the context information

[thisthat]

Suggested change

	* Tasks need to be aware of the `KeptnAppVersion` and `KeptnWorkloadInstance` version

[malon875875]

• I can’t think now of which information we would pass that would be sensitive
• Only a specific kind of Keptn task requires to know additional information for the promotion, other tasks would receive context information that is too big
  • I wonder if there should be a CRD KeptnTaskPromotionDefinition that would receive the additional promotion information

[thschue]

• I can’t think now of which information we would pass that would be sensitive

• Only a specific kind of Keptn task requires to know additional information for the promotion, other tasks would receive context information that is too big

  • I wonder if there should be a CRD KeptnTaskPromotionDefinition that would receive the additional promotion information

Which information would you like to pass over, for example? Personally, I'm not a fan of having too many CRDs, especially as the synchronization in a GitOps setup might get a bit tricky ...

[malon875875]

+1
I would love to see this PR implemented within the Keptn Roadmap

[mowies]

This KEP is basically fully implemented by keptn/lifecycle-toolkit#1394