KEP 98: Promotion Phase for GitOps use cases #107
Conversation
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
|
@thisthat pls re-review :) |
Signed-off-by: Moritz Wiesinger <[email protected]>
|
This EP makes much sense and enables many workflows (especially regarding promotion tasks). Could it be that this partially deprecates this one: #98 (on-success tasks but implemented in a new phase)? |
|
@thschue it's connected to the other KEP a bit, yes. But only in part of course. The thing is that you can't reference tasks here. So you basically have an unordered list of tasks that are run as a result of the success of the post-deployment phase. |
|
I will merge this next Monday (2024-02-12) if there will be no more additional feedback :) |
|
Two questions: Will this phase being executed as well when the status of a post deployment task or evaluation is failing? If so, do I get the results in my promotion task as well? |
|
No, it will only execute if the phases before it succeeded. |
|
epic ticket for this: keptn/lifecycle-toolkit#2907 |
No description provided.