Migrate to go 1.17

[vadasambar]

datadog-service uses go 1.16 in (e.g., in go.mod)

We should update to a newer version of go i.e., go 1.17 . This is so that we can keep up with the latest stable go version (1.19 at the time of writing this issue)

Definition of Done

• Migrate datadog-service code and integration tests to go 1.17
• Make sure tests run fine on your local machine (check this comment for how to run the tests)
• Create a new issue to migrate to go 1.18

[Mihai22125]

Hello @vadasambar, Can I help with this?

[vadasambar]

@Mihai22125 I'd love that. Thanks!

1. README has more info around setting up the service. You can use the kup.sh script to set up your local cluster with Keptn and Datadog. I think the script might have small bugs. If you find one, just create a Github issue for that.
2. We recently added tests which you can run on a cluster which has Keptn + Datadog installed. I am working on putting it on our CI/CD pipeline so that it runs on every PR but right now you will have to run the tests manually on your local machine. Here's how you do that:

Running tests on your local machine (takes around ~10m)

# port-forward Keptn api so that our tests can create/delete Keptn resources
kubectl port-forward svc/api-gateway-nginx 5000:80 -nkeptn # in a separate terminal window
# from datadog-service repo
export ENABLE_E2E_TEST=true
export KEPTN_ENDPOINT=http://localhost:5000/api
export KEPTN_API_TOKEN=$(kubectl get secret keptn-api-token -n keptn -ojsonpath='{.data.keptn-api-token}' | base64 -d)

# run tests
gotestsum --format standard-verbose -- -timeout=120m  ./test/e2e/...

[vadasambar]

If you face any issues or have any questions you can comment in this issue or reach me out on Keptn slack at @vadasambar.

[vadasambar]

We follow https://github.com/keptn/keptn/blob/master/CONTRIBUTING.md

[vadasambar]

@Mihai22125 are you working on this?

[vadasambar]

This issue is up for grabs.

[shivam-Purohit]

Can I take on this?

[vadasambar]

Sure. Thank you for showing interest @shivam-Purohit ❤️

[vadasambar]

The way to proceed with this issue:

1. Set up keptn with datadog-service on your local machine. Check quickstart for more info.
2. Make sure you can run the integration tests locally (check this comment on how to run tests)
3. Change the go version in all the go.mod files to go 1.17 and run the integration tests again
4. Make sure the integration tests pass

[shivam-Purohit]

GO I presume is already updated to 1.17 . Do you need to upgrade it to 1.18 or 1.19

[vadasambar]

Eventually yes. 1.17 -> 1.18 -> 1.19 feels safer than going directly to 1.18 or 1.19.

[shivam-Purohit]

So do we need to wait or just work on it right now?

[vadasambar]

just work on it right now?

We can start migrating to 1.17