Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Migrate datadog-service to cp-connector/go-sdk #56

Open
3 tasks
vadasambar opened this issue Aug 23, 2022 · 0 comments
Open
3 tasks

RFE: Migrate datadog-service to cp-connector/go-sdk #56

vadasambar opened this issue Aug 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@vadasambar
Copy link
Collaborator

Problem statement.
datadog-service uses the distributor sidecar for intercepting events from the shipyard-controller. Using distributor creates a problem where

Describe the solution you'd like
Whatever distributor is doing right now should go inside datadog-service i.e., we replace the sidecar with a library which does the same thing as the distributor. We can use the cp-connector library or go-sdk in place of distributor

Describe alternatives you've considered
I haven't considered any other alternatives which don't use a sidecar.

Additional context

TODO

  • PoC and see if we can use cp-connector or go-sdk in place of distributor (tests should pass; check this for how to run tests)
  • Create an issue to try it out with local development tools like Telepresence (so that we can add docs around it in our README)
  • If the PoC works fine, raise a PR to migrate datadog-service to go-sdk or cp-connector
@vadasambar vadasambar added the enhancement New feature or request label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant