feat: Added functionality to use vscode api in svelete #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ayush3160 <[email protected]>
|
@Akash-Singh04 Can you please review this. And let me know If any feature is breaking because of this change. |
SkySingh04
approved these changes
Aug 3, 2024
|
@ayush3160 You can safely delete the sidebar.js file now 👍🏻 |
Signed-off-by: ayush3160 <[email protected]>
|
@Akash-Singh04 , I have removed sidebar.js file please have a look. |
|
@ayush3160 You'll also need to remove its references from SidebarProvider.ts |
|
@Akash-Singh04 , I think I have done that can you please mention which reference you are talking about |
|
@ayush3160 yep that's all good! |
Open
1 task
|
@ayush3160 can you please resolve the conflicts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #2144
In this PR I have added the functionality to call vscode api directly from svelte files and hence removing the dependency over the sidebar.js file completely.