fix: add #main to ENTRY_POINT_ELEMENTS#307
Open
cehbz wants to merge 1 commit into
Open
Conversation
'main' matches <main> elements but not id="main". Pages with <div id="main"> as the content container can fail to match, resulting in spurious matches of unrelated elements. Groups #main with main and [role="main"]. Adds regression fixture from thailand.embassy.gov.au.
Owner
|
Which site does this affect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'#main'toENTRY_POINT_ELEMENTSinsrc/constants.ts,grouped with the existing
'main'and'[role="main"]'selectors'main'entry only matches<main>elements — it doesnot match
<div id="main">'#main', pages usingid="main"fall through tolower-priority selectors like
'#content', which on some pagesmatches a footer or navigation container
Reproduction
The fixture is from thailand.embassy.gov.au, which uses:
<div class="col-md-9" id="main">for the actual passportapplication content
<footer><div id="content" class="container">for site-widenavigation links
Before this fix, Defuddle selected
footer > div#contentvia the#contententry point and extracted only navigation boilerplate.With
#mainadded, Defuddle correctly identifiesdiv#mainas thecontent container.
Test plan
entry-point--id-mainconfirms correct extraction