Fix Linux release DuckDB link#393
Merged
Merged
Conversation
roborev: Combined Review (
|
roborev: Combined Review (
|
Contributor
|
I broke this in #390, sorry about that! |
sweenzor
added a commit
to sweenzor/msgvault
that referenced
this pull request
Jun 19, 2026
Hardening on top of kenn-io#393 (which fixed the Linux release break by moving to ubuntu:22.04, where the GCC 12 libstdc++ is available). Build with gcc-12 and embed libstdc++/libgcc statically so the released binary has no runtime libstdc++ (GLIBCXX) dependency; kenn-io#393 leaves it dynamically linked, requiring GLIBCXX_3.4.30. Also pin the build image by digest, and add a guard that fails the build if libstdc++ ever links dynamically. Verified in a matching ubuntu:22.04 arm64 container: links cleanly, runs, no dynamic libstdc++. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
git diff --check HEAD~1..HEAD.