fix: wire workspace list actions#562
Open
mariusvniekerk wants to merge 1 commit into
Open
Conversation
Workspace row menus exposed push, pull, reveal, and delete affordances, but several were UI-only placeholders. That creates a dangerous mismatch for users managing real worktrees from the list. Add foreground workspace branch sync endpoints that keep normal git hooks enabled, reject dirty or diverged states instead of silently mutating them, and expose the same operations through fleet proxies. The workspace list now shows per-row pending state and surfaces failed push, pull, reveal, and delete attempts through existing toast/error handling. Validation: git diff --check; go test ./internal/workspace -shuffle=on; go test ./internal/server -run 'TestWorkspace(PushBranchRoutePushesAheadBranch|PullBranchRouteFastForwardsBehindBranch|PullBranchRouteRejectsDirtyWorktree|RevealRouteOpensWorkspacePath)$' -shuffle=on; cd frontend && node ../node_modules/vite-plus/bin/vp test run --project unit src/lib/components/terminal/WorkspaceListSidebar.test.ts; node node_modules/vite-plus/bin/vp run frontend-package-typecheck Generated with Codex Co-authored-by: Codex <codex@openai.com>
Collaborator
Author
|
generated by a clanker |
roborev: Review Unavailable (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace context menus were exposing actions that looked available but did not actually run. That is a bad failure mode for a maintainer console because users need to trust that visible workspace actions either execute or report a real failure.
This wires push, pull, reveal, and delete from the workspace list, keeps foreground push/pull behavior conservative around dirty or diverged worktrees, and shows pending/failure feedback while long-running git operations are active.
Screenshot:
Validated locally with the focused workspace/server Go tests, the workspace sidebar unit tests, frontend typecheck, and the repository commit hooks.
generated by a clanker