Skip to content

Add workspace row context menu#561

Merged
mariusvniekerk merged 3 commits into
mainfrom
feat/workspace-row-context-menu
Jun 19, 2026
Merged

Add workspace row context menu#561
mariusvniekerk merged 3 commits into
mainfrom
feat/workspace-row-context-menu

Conversation

@mariusvniekerk

Copy link
Copy Markdown
Collaborator

Workspace rows now expose secondary actions through a right-click menu, keeping row click focused on opening the workspace while putting branch sync, copy, provider URL, and cleanup affordances in a familiar activity-filter style.

The menu hides local filesystem actions for fleet workspaces, uses Finder wording on macOS local rows, and avoids offering push or pull on diverged branches until a dedicated safe mutation path exists.

mariusvniekerk and others added 2 commits June 19, 2026 18:25
Workspace rows need secondary actions that do not belong on the primary row click or the PR/issue bubble. Add a right-click menu so maintainers can refresh git status, copy refs, open provider URLs, and reach local filesystem affordances without crowding the rail.

The menu is host-aware: fleet workspaces do not expose local path or reveal actions, macOS local rows use Finder language, and diverged branches do not offer push or pull actions. Push and pull entries remain constrained to simple ahead-only or behind-only rows until a dedicated git mutation path exists.

Generated with Codex
Co-authored-by: Codex <codex@openai.com>
The row context menu was carrying extra labels for small action clusters, which made the popup feel more structured than the actual choice set warranted. Keeping the separators while removing the Copy and Provider headings makes the menu scan closer to the activity filter styling without adding noise.

Validation: targeted WorkspaceListSidebar unit test, full frontend unit suite, frontend package typecheck, Svelte autofixer, git diff --check, and Chromium Playwright screenshot capture.

Generated with Codex
Co-authored-by: Codex <codex@openai.com>
@roborev-ci

roborev-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

roborev: Combined Review (d0f7b20)

Summary verdict: one medium UI regression should be fixed before merge.

Medium

  • frontend/src/lib/components/terminal/WorkspaceListSidebar.svelte:1019: The context menu is rendered inside .workspace-list-sidebar, which has overflow: hidden and container-type: inline-size. That can cause the position: fixed menu to be clipped or positioned relative to the sidebar instead of the viewport. At the default narrow rail width, right-clicking most rows can leave the 224px menu clipped or misplaced.

    Fix: Render the menu in an unclipped top-level overlay/portal such as document.body, or position it relative to the sidebar bounds with visible overflow, and cover the geometry with a Playwright test.


Panel: ci_default_security | Synthesis: codex, 9s | Members: codex_default (codex/default, done, 5m23s), codex_security (codex/security, done, 36s) | Total: 6m8s

The workspace row context menu needs to be positioned against the viewport, but rendering it inside the sidebar left it inside an overflow-hidden container-query rail. Moving the menu to a sibling overlay keeps the same behavior while avoiding sidebar clipping and container-relative fixed positioning.

Adds a browser regression that opens the menu at the edge of the workspace rail and checks both that it is no longer a sidebar descendant and that its bounding box remains inside the viewport.

Validation: Svelte autofixer, targeted WorkspaceListSidebar unit test, affected workspaces Playwright spec in Chromium and Firefox, full frontend unit suite, frontend package typecheck, and git diff --check.

Generated with Codex
Co-authored-by: Codex <codex@openai.com>
@roborev-ci

roborev-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

roborev: Combined Review (4c0bc22)

No Medium, High, or Critical issues were found.

Both reviews are clean at the requested severity threshold.


Panel: ci_default_security | Synthesis: codex, 4s | Members: codex_default (codex/default, done, 4m15s), codex_security (codex/security, done, 22s) | Total: 4m41s

@mariusvniekerk mariusvniekerk merged commit 8f414ba into main Jun 19, 2026
16 checks passed
@mariusvniekerk mariusvniekerk deleted the feat/workspace-row-context-menu branch June 19, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant