Skip to content

fix(api): expect absent rejectionReason instead of null #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kelleyglenn merged 1 commit into from
Feb 23, 2026
Merged

fix(api): expect absent rejectionReason instead of null #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions api/tests/video-service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
});

if (!trustedLogin.ok()) {
test.skip(true, "Trusted seed user not available");

Check warning on line 193 in api/tests/video-service.spec.ts

View workflow job for this annotation

GitHub Actions / integration 

Unexpected use of the `.skip()` annotation
return;
}

Expand Down Expand Up @@ -360,14 +360,16 @@

expect(listResponse.ok()).toBeTruthy();
const listBody = await listResponse.json();
// Video should be PENDING (no rejection reason yet)
// Video should be PENDING with no rejection reason.
// Jackson non_null config omits null fields, so rejectionReason
// is absent rather than explicitly null.
const found = listBody.content.find(
(v: { id: string }) => v.id === video.id,
);
expect(found).toMatchObject({
status: "PENDING",
rejectionReason: null,
});
expect(found.rejectionReason).toBeUndefined();
}
// If 409, video already exists from a prior run — test is still valid:
// the schema test (rejectionReason field) was verified in a previous run
Expand Down
Loading