fix: add SERVER_API_URL and document UI polish plan (#97) - #98
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The web-app's generateMetadata runs server-side inside the Docker container where localhost:8080 doesn't reach the API gateway. SERVER_API_URL uses the Docker network hostname instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Documents the global safety-net threshold and per-directory thresholds in 08-DevelopmentStandards.md so new files can't ship with 0% coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelleyglenn
changed the title
Server-side generateMetadata() fetches need the Docker-internal hostname, not the public URL. Matches the same fix in docker-compose.yml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-compose.yml: AddedSERVER_API_URL: http://api-gateway:8080/api/v1to web-app service — fixes server-sidegenerateMetadata()fetches that couldn't reach the API gateway from inside Docker (localhost:8080 doesn't work between containers)docs/plans/: Added UI polish design and implementation plan docs for web-app issues Find opportunities to share code between the services #21, feat: pass Mapbox token to web-app Docker build #35, Update docs: replace Google Maps references with Mapbox, update service statuses #41, fix: add search-moderation-events SQS queue to avoid competing consumers #65, Documentation updates for clarified guidelines #66Test plan
docker-compose --profile backend --profile frontend upcurl -s http://localhost:3000/videos/<seed-video-id> | grep '<title>'shows dynamic video title (not "Video | AccountabilityAtlas")curl -s http://localhost:3000/users/<seed-user-id> | grep '<title>'shows dynamic user nameCloses #97
🤖 Generated with Claude Code