Skip to content

Added Button component by Amadu S Camara #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amadusadjocamara
Copy link

This pull request adds a simple button component to the collection. It includes styling for the button etc.. The component is created by Amadu S Camara https://github.com/amadusadjocamara.

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-devs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 1:20pm

@kelixirr
Copy link
Owner

kelixirr commented Dec 26, 2024

Hi, that's great. I am glad that you are the first person and I am happy to offer some feedback.

<pre className='styles.codeBlock'>
                <code>

                </code>

            </pre>

            <Author name="Amadu Sadjo Camara" githubLink="https://github.com/amadusadjocamara" />;
        </div>

So, I guess this you are taking from the example on the Website and ReadMe file. I really appreciate it but please don't use that same example. Come up with something on your own create something you learnt in the course. Based on that create something or something out of your thinking. Also, no need to use the code and style.codeblock etc here because it is not needed. All you have to do is write this:

<Author name="Amadu Sadjo Camara" githubLink="https://github.com/amadusadjocamara" />;

And also make sure that you are importing Author component. The code I have written on website and in the ReadMe file is just for the sake of example. Create a new component of your own and then update me. Also, use index.css file to take the root variables for your css.

@kelixirr kelixirr added the question Further information is requested label Dec 26, 2024
Copy link
Owner

@kelixirr kelixirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make changes as discussed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants