This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Actually allowing 30MB data to be stored #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update here? |
|
The trouble with this patch is its mysql specific. The code should be changed to BLOB, but if anything this is a bug in mysql that it insists on departing from other databases in having different blobs. |
|
Your point makes sense @xpusostomos but if I consider MongoDB as "other databases", there is no need to even specifying a length as the database doesn't support any kind of such validation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsynchronousMailAttachmentdomain adds amaxLengthvalidation of 30MB but according to this SO answer https://stackoverflow.com/questions/3503841/jpa-mysql-blob-returns-data-too-long, the default type ofbyte[] contentisBLOBhence only65,535 bytes(64 kb) is allowed. This PR changing the datatype toLONGBLOBto allow saving at least 30MB of file.