Skip to content

Commit

Permalink
Do not consider port 0 as a missing info (#181)
Browse files Browse the repository at this point in the history
I found a service type _device-info._tcp.local. which does announce a port 0. It's used by the Linux samba implantation to announce some additional information for Mac-OS based computers, but without an actual port, by setting the port to 0.

So the _device-info.tcp.local. is never resolved for me using mdns-sd.
This change should fix the issue.
  • Loading branch information
hrzlgnm authored Mar 17, 2024
1 parent c4caa10 commit ed1541f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/service_info.rs
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ impl ServiceInfo {
let some_missing = self.ty_domain.is_empty()
|| self.fullname.is_empty()
|| self.server.is_empty()
|| self.port == 0
|| self.addresses.is_empty();
!some_missing
}
Expand Down

0 comments on commit ed1541f

Please sign in to comment.