-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Catch errors about comparison CEL #5347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@diegovb-sys is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5347 +/- ##
==========================================
- Coverage 46.64% 46.31% -0.33%
==========================================
Files 175 176 +1
Lines 18263 18447 +184
==========================================
+ Hits 8519 8544 +25
- Misses 9744 9903 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@diegovb-sys can you fix the failing UT? |
Closes #5340
📑 Description
As I've posted in the Issue. There are some scenarios, where specific alert fields can be casted to other type than the expected.
An example is to use Mapping to dismiss an alert and after of that, read that field in a WF. The WF would expect a boolean value, but it will received a string, so this will cause a celpy error.
In order to face that problem, I've implemented (inside the Except) in WF and Incidents scopes a cast to the original values. (Using the ones defined in AlertDTO)
✅ Checks
ℹ Additional Information