This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
dev: parse v0.11.0 DA calldata #1209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
suggested changes
Oct 23, 2023
Comment on lines
45
to
+50
| #[clap(long)] | ||
| pub da_layer: Option<DaLayer>, | ||
|
|
||
| /// Choose a supported DA Layer | ||
| #[clap(long)] | ||
| pub da_conf: Option<String>, |
There was a problem hiding this comment.
Make them an arg group.
The whole group is optional, but as soon as one is used, all must be
| @@ -76,57 +82,82 @@ where | |||
| { | |||
| pub async fn prove_current_block(da_mode: DaMode, client: Arc<C>, madara_backend: Arc<mc_db::Backend<B>>) { | |||
| let mut storage_event_st = client | |||
| .storage_changes_notification_stream(None, None) | |||
| .storage_changes_notification_stream(None, Some(&[(SubStorageKey(twox_128(PALLET_STARKNET).into()), None)])) | |||
There was a problem hiding this comment.
I think you can go (None, None) unti we get some light on paritytech/polkadot-sdk#1989
| accessed_addrs.insert(ContractAddress(bytes_to_key(&rest_key))); | ||
| } else if child_key == twox_128(STARKNET_STORAGE) { | ||
| // collect storage update information in state diff | ||
| if rest_key.len() > 32 { |
There was a problem hiding this comment.
I don't think this could be false.
|
holding for work here: #1217 |
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThinStateDiffstructure (potential to add scale encoding to this api type and save this to the kv db)--da-confas the dev file overrides don't include the da configPull Request type
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
minor - if use or import of exposed util functions