Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only six's major version #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix only six's major version #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b503036
Fix only six's major version
erdnaxeli Apr 25, 2019
810c993
Bump version to 0.5.2
erdnaxeli Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pycryptodome>=3.4
requests>=2.5,<3.0
six~=1.10
six>=1.10,<2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask, what does this have to do with six's major version? I may be incorrect, but I don't see the difference this change makes according to https://www.python.org/dev/peps/pep-0440/#compatible-release. Please elucidate.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masojus the current code is pinning to any (generally latest) version of 1.10.x. This PR is allowing 1.11.x, 1.12.x, etc.

The problem here is that it's causing conflicts during dependency resolution, so if I have a package that needs six > 1.11, I can't install both this package and the other, even though this package shouldn't be affected by updating six's minor version (second part of the version number).

2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

setup(
name="keen",
version="0.5.1",
version="0.5.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several other files have to change to release another minor version.

description="Python Client for Keen IO",
long_description=codecs.open(os.path.join('README.rst'), 'r', encoding='UTF-8').read(),
author="Keen IO",
Expand Down