Commit Cargo.lock #126
Open
Commit Cargo.lock #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was trying to package
kdl-lspfor Nix, I realized that this project currently does not commit itsCargo.lock.As per the Cargo Book, it is considered best practice to have the lock file under version control. ("When in doubt, check Cargo.lock into the version control system (e.g. Git)")
I tried to search throughout this repository (in issues, discussions and documentation) whether this had been discussed before, but my cursory search did not yield anything.
Is there a reason for this choice? If so, perhaps documenting it would be best.