Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config for selection mark/unmark symbols #594

Merged

Conversation

vapourismo
Copy link
Contributor

Configuration items uda.taskwarrior-tui.{un,}mark-selection.indicator are not used when rendering the corresponding symbols in the main table.

Example configuration:

uda.taskwarrior-tui.selection.indicator=a
uda.taskwarrior-tui.mark.indicator=b
uda.taskwarrior-tui.unmark.indicator=c
uda.taskwarrior-tui.mark-selection.indicator=x
uda.taskwarrior-tui.unmark-selection.indicator=y

The result looks like this. x and y are nowhere to be seen.

With this fix it looks like this.

@kdheepak
Copy link
Owner

kdheepak commented Aug 2, 2024

Thanks for the PR!

@kdheepak kdheepak merged commit 14e60d5 into kdheepak:main Nov 13, 2024
10 of 11 checks passed
@kdheepak kdheepak mentioned this pull request Jun 11, 2024
kdheepak added a commit that referenced this pull request Nov 14, 2024
## 🤖 New release
* `taskwarrior-tui`: 0.26.3 -> 0.26.4

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.26.4](v0.26.3...v0.26.4)
- 2024-11-14

### Added

- Add code coverage to CI
- Cache taskwarrior compilation
- Build taskwarrior CI against stable

### Fixed

- Disable broken MacOS compression
- Append target for unique artifact names
- Update the upload-artifacts due to deprecation of v2
- Deprecation warning

### Other

- Add us as Co-Maintainers
([#606](#606))
- Apply clippy lint
- Merge build workflows
- Modernize CI/CD components
- Use config for selection mark/unmark symbols
([#594](#594))
- *(deps)* bump the cargo-dependencies group with 4 updates
([#584](#584))
- *(deps)* bump tokio from 1.37.0 to 1.38.0 in the cargo-dependencies
group ([#582](#582))
- *(deps)* bump the cargo-dependencies group with 3 updates
([#580](#580))
- Update taskwarrior-tui.bash
- *(deps)* bump the cargo-dependencies group across 1 directory with 20
updates ([#573](#573))
- *(deps)* Bump to ratatui v0.26
- *(deps)* bump actions/checkout from 2 to 4
([#569](#569))
- *(deps)* bump peaceiris/actions-gh-pages from 3 to 4
([#568](#568))
- *(deps)* bump actions/setup-python from 1 to 5
([#566](#566))
- *(deps)* bump actions/setup-python from 1 to 5
- Add dependabot.yml
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants