-
Notifications
You must be signed in to change notification settings - Fork 3
fix(fe): restore TypeTag.tsx and fix lint errors blocking CI #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # CI/CD 안정화 - tiggle, calynda, AIVA-SaaS | ||
| > 날짜: 2026-04-12 | 회차: 1 | 상태: 진행중 | ||
|
|
||
| ## 요청 내용 | ||
| tiggle, calynda, aiav-bb(AIVA-SaaS) 세 프로젝트의 GitHub Actions CI가 자주 실패하는 원인 분석 및 안정화 | ||
|
|
||
| ## 영향 범위 분석 | ||
|
|
||
| ### Tiggle (72% CI 실패율) | ||
| - **근본 원인**: `TypeTag.tsx` 파일 누락 → 모든 FE 빌드 실패 | ||
| - **부가 원인**: `DetailPage/index.tsx` prettier 포맷팅 오류, `NotFoundPage.tsx` import 순서 오류 | ||
| - 변경 파일: | ||
| - `frontend/tiggle/src/components/atoms/TypeTag/TypeTag.tsx` (복구) | ||
| - `frontend/tiggle/src/pages/DetailPage/index.tsx` (prettier 수정) | ||
| - `frontend/tiggle/src/pages/NotFoundPage.tsx` (import order 수정) | ||
|
|
||
| ### Calynda (CI 통과 중, 개선 필요) | ||
| - **이슈**: FE(Flutter) 테스트가 CI에 없음. 15개 테스트 파일 존재하지만 미실행 | ||
| - 변경 파일: | ||
| - `be/.github/workflows/ci.yml` (frontend-test job 추가) | ||
| - `be/.github/workflows/deploy-nas.yml` (test-frontend gate job 추가) | ||
|
|
||
| ### AIVA-SaaS (현재 안정 - 최근 5회 연속 성공) | ||
| - 과거 이슈: Flyway 마이그레이션 충돌, BLoC 상태관리 버그 (해결됨) | ||
| - 현재 안정 상태 → 즉시 수정 불필요 | ||
|
|
||
| ## 작업 계획 | ||
| | # | 작업 | 프로젝트 | 파일 | 난이도 | | ||
| |---|------|---------|------|--------| | ||
| | 1 | TypeTag.tsx 복구 | Tiggle | atoms/TypeTag/TypeTag.tsx | S | | ||
| | 2 | prettier/import 오류 수정 | Tiggle | DetailPage, NotFoundPage | S | | ||
| | 3 | FE 빌드 + BE 테스트 로컬 검증 | Tiggle | - | S | | ||
| | 4 | Flutter 테스트 CI 추가 | Calynda | ci.yml, deploy-nas.yml | M | | ||
| | 5 | AIVA-SaaS 현황 분석 | AIVA-SaaS | - | S | | ||
|
|
||
| ## 성능 설계 | ||
| - CI 실행 시간 영향: Flutter 테스트 추가로 Calynda CI ~2-3분 증가 (허용 범위) | ||
| - Calynda deploy에서 test-frontend이 test-backend과 병렬 실행되므로 총 시간 증가 최소화 | ||
|
|
||
| ## 검증 계획 | ||
| - [x] Tiggle BE 테스트 통과 (`./gradlew :tiggle:test`) | ||
| - [x] Tiggle FE 빌드 통과 (`npm run build`) | ||
| - [x] Calynda CI YAML 문법 검증 | ||
| - [ ] Tiggle 커밋 후 CI 통과 확인 (GitHub Actions) | ||
| - [ ] Calynda 커밋 후 CI 통과 확인 (GitHub Actions) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { HTMLAttributes } from "react"; | ||
|
|
||
| import cn from "classnames"; | ||
|
|
||
| import { TypeTagStyle } from "@/components/atoms/TypeTag/TypeTagStyle"; | ||
| import { Tx, TxType } from "@/types"; | ||
|
|
||
| interface TypeTagProps extends HTMLAttributes<HTMLDivElement> { | ||
| size: "md" | "lg"; | ||
| txType: TxType; | ||
| } | ||
|
|
||
| export default function TypeTag({ | ||
| size, | ||
| txType, | ||
| className, | ||
| ...props | ||
| }: TypeTagProps) { | ||
| return ( | ||
| <TypeTagStyle | ||
| className={cn("type-tag", txType, className, size)} | ||
| {...props} | ||
| > | ||
| <p className="label"> | ||
| {txType === Tx.OUTCOME | ||
| ? "지출" | ||
| : txType === Tx.REFUND | ||
| ? "환불" | ||
| : "수익"} | ||
| </p> | ||
| </TypeTagStyle> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdownlint MD058 경고를 해소해주세요.
Line 28의 테이블이 빈 줄로 둘러싸여 있지 않아
blanks-around-tables경고가 발생합니다. 문서 lint 안정화를 위해 테이블 전/후에 빈 줄을 넣는 것이 좋습니다.수정 예시
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 28-28: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🤖 Prompt for AI Agents