Skip to content

✨ Use .WithCluster and .WithNamespace #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: kcp-1.32.3
Choose a base branch
from
Open

✨ Use .WithCluster and .WithNamespace #112

wants to merge 2 commits into from

Conversation

ntnn
Copy link
Member

@ntnn ntnn commented Jun 30, 2025

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jun 30, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign scheeles for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 30, 2025
This was referenced Jun 30, 2025
Open
Open
ntnn added 2 commits July 1, 2025 11:48
@ntnn
Use .WithCluster and .WithNamespace
2451279 
Signed-off-by: Nelo-T. Wallus <[email protected]>
@ntnn
codegen
db1166e 
Signed-off-by: Nelo-T. Wallus <[email protected]>
@ntnn ntnn force-pushed the update-client-go-3 branch from 905296f to db1166e Compare July 1, 2025 09:48
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2025
@ntnn ntnn changed the title [WIP] ✨ Reduce cluster-lister-gen ✨ Use .WithCluster and .WithNamespace Jul 1, 2025
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2025
@kcp-ci-bot
Copy link
Contributor

@ntnn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-code-generator-test db1166e link true /test pull-code-generator-test
pull-code-generator-lint db1166e link true /test pull-code-generator-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntnn @kcp-ci-bot