Skip to content

Allow references to select multiple values #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2025
Merged

Allow references to select multiple values #83

merged 5 commits into from
Jul 8, 2025

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jun 27, 2025

Summary

So far the agent has 3 different modes for finding related objects:

  • references
  • templates
  • label selectors

Only label selectors were currently able to handle many objects for 1 single related object configuration. This proved a bit too limitting.

This PR extends references to also allow to select multiple values. For this a query would look like spec.users.#.name to select all the names of all users in an object.

What Type of PR Is This?

/kind feature

Release Notes

References can now return lists of values to allow a single related resource configuration to match many Kubernetes objects at once.

@kcp-ci-bot kcp-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 27, 2025
@xrstf xrstf requested a review from embik July 1, 2025 10:50
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a1f7a9cab9aa989021562fe9ba3133e0f628b42

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
@kcp-ci-bot kcp-ci-bot merged commit bc2d16a into main Jul 8, 2025
9 checks passed
@kcp-ci-bot kcp-ci-bot deleted the multi-refs branch July 8, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants