Skip to content

test: unit and property coverage for strategies#40

Open
Ishant5436 wants to merge 1 commit into
kcolbchain:mainfrom
Ishant5436:feat/add-tests
Open

test: unit and property coverage for strategies#40
Ishant5436 wants to merge 1 commit into
kcolbchain:mainfrom
Ishant5436:feat/add-tests

Conversation

@Ishant5436

@Ishant5436 Ishant5436 commented Jun 6, 2026

Copy link
Copy Markdown

adds unit and property-based test coverage for the constant_spread and adaptive_spread quoting strategies. the property tests uncovered a type bug in adaptive_spread that is fixed in this pr.

fixes #29

- Added unit tests for constant and adaptive spread strategies
- Added property tests using Hypothesis for quote formation math invariants
- Fixed a bug in adaptive_spread returning numpy scalars instead of python floats
- Added GitHub action for pytest
@abhicris

abhicris commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Audit verdict: safe

Standard test coverage PR with legitimate property-based testing, one helpful type-casting fix for JSON serialization, no malicious code or supply-chain risks.

Audited by the kcolbchain PR pipeline. See pipeline docs.

@abhicris

abhicris commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Welcome to kcolbchain, @Ishant5436 — glad you're here. 🌱

Here's what happens from this PR:

  1. Our automated review looks for obvious issues (tests, secrets, size) within a couple of hours.
  2. If it's clean and CI passes, we merge without back-and-forth.
  3. If we need changes, we'll leave a specific comment — not a generic nit. Push another commit and we re-review.

While you wait:

  • Run the repo's tests locally (see the repo README.md).
  • Keep the PR scoped to one concern — bigger PRs land slower.
  • Don't commit tokens or .env contents.

What happens after your first merge

Thanks for writing the code. We're building this to last.

@Ishant5436 Ishant5436 changed the title test: unit and property coverage for strategies (Fixes #29) test: unit and property coverage for strategies Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: bootstrap tests/ — unit + property coverage for strategies + quote-formation

2 participants