test: unit and property coverage for strategies#40
Open
Ishant5436 wants to merge 1 commit into
Open
Conversation
- Added unit tests for constant and adaptive spread strategies - Added property tests using Hypothesis for quote formation math invariants - Fixed a bug in adaptive_spread returning numpy scalars instead of python floats - Added GitHub action for pytest
Contributor
|
🤖 Audit verdict: Standard test coverage PR with legitimate property-based testing, one helpful type-casting fix for JSON serialization, no malicious code or supply-chain risks. Audited by the kcolbchain PR pipeline. See pipeline docs. |
Contributor
|
Welcome to kcolbchain, @Ishant5436 — glad you're here. 🌱 Here's what happens from this PR:
While you wait:
What happens after your first merge
Thanks for writing the code. We're building this to last. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds unit and property-based test coverage for the
constant_spreadandadaptive_spreadquoting strategies. the property tests uncovered a type bug inadaptive_spreadthat is fixed in this pr.fixes #29