Fix: Detach open command execution #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simply switches `os.execute` with `vim.fn.jobstart` with `detach` set to `true`, making the editor available after opening the problems' url allowing you to edit, while the browser is running. The `detach` option keeps the browser open after the editor shuts down. It is not the default behavior (which would make the browser shut down with the editor, I find the introduced behavior to be more appropriate). NOTE: This commit has been tested only on Linux; but I don't suppose there would be any meaningful difference.
|
For added context, the current behavior halts the editor; as |
AlOwain
changed the title
|
thanks |
kawre
added a commit
that referenced
this pull request
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simply switches
os.executewithvim.fn.jobstartwithdetachset totrue, making the editor available after opening the problems' url allowing you to edit, while the browser is running.The
detachoption keeps the browser open after the editor shuts down. It is not the default behavior (which would make the browser shut down with the editor, I find the introduced behavior to be more appropriate).NOTE: This commit has been tested only on Linux; but I don't suppose there would be any meaningful difference.