Skip to content

fix: head gesture detection biased toward 'yes' (#555) #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisisAcidic wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −20
Open

fix: head gesture detection biased toward 'yes' (#555) #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions android/app/src/main/java/me/kavishdevar/librepods/utils/GestureDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,33 +367,28 @@ fun startDetection(doNotStop: Boolean = false, onGestureDetected: (Boolean) -> U
val requiredExtremes = getRequiredExtremes()
Log.d(TAG, "Current required extremes: $requiredExtremes")

if (verticalPeaks.size + verticalTroughs.size >= requiredExtremes) {
val verticalConfidence = if (verticalPeaks.size + verticalTroughs.size >= requiredExtremes) {
val allExtremes = (verticalPeaks + verticalTroughs).sortedBy { it.first }
calculateConfidenceScore(allExtremes, isVertical = true)
} else 0.0

val confidence = calculateConfidenceScore(allExtremes, isVertical = true)

Log.d(TAG, "Vertical motion confidence: $confidence (need $minConfidenceThreshold)")

if (confidence >= minConfidenceThreshold) {
Log.d(TAG, "\"Yes\" Gesture Detected (confidence: $confidence, extremes: ${allExtremes.size}/$requiredExtremes)")
return true
}
}

if (horizontalPeaks.size + horizontalTroughs.size >= requiredExtremes) {
val horizontalConfidence = if (horizontalPeaks.size + horizontalTroughs.size >= requiredExtremes) {
val allExtremes = (horizontalPeaks + horizontalTroughs).sortedBy { it.first }
calculateConfidenceScore(allExtremes, isVertical = false)
} else 0.0

val confidence = calculateConfidenceScore(allExtremes, isVertical = false)
Log.d(TAG, "Confidence: vertical=$verticalConfidence horizontal=$horizontalConfidence (need $minConfidenceThreshold)")

Log.d(TAG, "Horizontal motion confidence: $confidence (need $minConfidenceThreshold)")
val maxConfidence = max(verticalConfidence, horizontalConfidence)
if (maxConfidence < minConfidenceThreshold) return null

if (confidence >= minConfidenceThreshold) {
Log.d(TAG, "\"No\" Gesture Detected (confidence: $confidence, extremes: ${allExtremes.size}/$requiredExtremes)")
return false
}
return if (verticalConfidence >= horizontalConfidence) {
Log.d(TAG, "\"Yes\" Gesture Detected (vertical=$verticalConfidence, horizontal=$horizontalConfidence)")
true
} else {
Log.d(TAG, "\"No\" Gesture Detected (vertical=$verticalConfidence, horizontal=$horizontalConfidence)")
false
}

return null
}

private fun clearData() {
Expand Down
Loading