Skip to content

Create http client per request call #3

Description

@sajjaadalipour

Why do you build the HttpClient in the execute method?

I mean this part of the code:

image

It's better if make the HttpClient instance singleton or get that as a dependency in the KavenegarApi class.

If you want my recommendation, it's better if you give both solutions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions