add connection icon animation type and refactor connect logic #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix deps: https://todo.sr.ht/~eliasnaur/gio/471 go get -u broke some dependencies of gio
when a previous Page becomes Current, call its Start method.
TODO: find a more elegant solution to make an animated connection icon.
create a new type to hold layout methods with a worker routine that updates the connection icon while the page is displayed.
adds catshadow.Status() which indicates the current connection state of the client.
add re-pin to latest katzenpost@add_status_to_catshadow branch
triggered by attempting to build, but not by the go get which re-pinned katzenpost, wtf?
so, this builds now, but clicking the icon crashes with: fatal error: sync: Unlock of unlocked RWMutex
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| case catshadow.StateConnecting: | ||
| // ignore | ||
| case catshadow.StateOffline: | ||
| a.c.Online(context.TODO()) |
There was a problem hiding this comment.
G104: Errors unhandled.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| func (a *App) doConnectClick() { | ||
| switch a.c.Status() { | ||
| case catshadow.StateOnline: | ||
| a.c.Offline() |
There was a problem hiding this comment.
G104: Errors unhandled.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
I merged |
now it runs but isn't connecting
|
ok, now it doesn't crash, but, it also isn't connecting. i did see it animate briefly though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft, because it is pinned to a PR branch of katzenpost.
this also probably breaks provider selection at startup.
do not merge.