Skip to content

Commit

Permalink
sub: update subtitles if current track is an image
Browse files Browse the repository at this point in the history
Any track that has attached picture is also always considered an image.
Not every image is neccesarily an attached picture though. So change the
check here to capture more possible cases where we should be updating
the subtitle. With the previous commits, this fixes mpv-player#12387.
  • Loading branch information
Dudemanguy committed Oct 23, 2023
1 parent 4709a94 commit 7847f15
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion player/sub.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ static bool update_subtitle(struct MPContext *mpctx, double video_pts,
if (mpctx->video_out && mpctx->video_status == STATUS_EOF &&
(mpctx->opts->subs_rend->sub_past_video_end ||
!mpctx->current_track[0][STREAM_VIDEO] ||
mpctx->current_track[0][STREAM_VIDEO]->attached_picture)) {
mpctx->current_track[0][STREAM_VIDEO]->image)) {
if (osd_get_force_video_pts(mpctx->osd) != video_pts) {
osd_set_force_video_pts(mpctx->osd, video_pts);
osd_query_and_reset_want_redraw(mpctx->osd);
Expand Down

0 comments on commit 7847f15

Please sign in to comment.