Adjust pruning proof root per level #627
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When trying to find the estimated root per block level,
find_sufficient_root
will adjust the required level 0 depth in powers of 2 based on how much higher the current level being processed is against the current level of the DAG. This can lead to cases where a higher level can have too many headers on it if the network gets an influx of significantly high hashrate and then that hashrate leaves.It testnet-11 where someone put an ASIC on the network and left, the results are as follows:
Note that this is really only occurs in testnets since it requires hashrate to abruptly increase (x8 or x16 kind of increase) which is unexpected to occur in mainnet.
Solution: After calculating the GD store for a level and assuming we satisfy all requirements for a pruning proof of a level, we can now call
block_at_depth
on it. Use that and the old root finding logic (from before #494) to determine the true sufficient root we need. This solution results in: