File-based Storage #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for taking care of the file system integration! Apologies for the delayed response. I made a few comments on your code, but once those are resolved, I'd love to get this integrated. Excuse me if my comments seem too pedantic, but I think code is only good insofar as it's consistent. Feel free to argue with my points if you feel differently. |
Author
|
I believe I made all the changes. It was interesting getting a chance to work with someone else's coding style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at using the file writer / reader apis. Should properly migrate localStorage based styles, but as of now, seems to require a permission acceptance.