Fix model.split error when model is array#126
Open
bledden wants to merge 1 commit intokarpathy:masterfrom
Open
Fix model.split error when model is array#126bledden wants to merge 1 commit intokarpathy:masterfrom
bledden wants to merge 1 commit intokarpathy:masterfrom
Conversation
Fixes karpathy#117 - handles arrays, null/undefined, and missing slashes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
eddiefleurent
added a commit
to eddiefleurent/llm-council
that referenced
this pull request
Jan 30, 2026
Tier 1 (High Value, Low Risk): - PR #72: Use CHAIRMAN_MODEL for title generation (configurable) - PR #51: Validate OPENROUTER_API_KEY at startup (fail fast) - PR #5: Fix text overflow on chat interface (CSS fixes) - PR #69: Prevent conversation switching while streaming - PR karpathy#110: Copy functionality (copy buttons for responses) Tier 2 (Good Features, Moderate Complexity): - PR karpathy#126: Fix model.split error when model is array (defensive) - PR karpathy#127: Structured error propagation for API failures - PR #67: Continuous conversation mode + prevent empty convos - PR #90: Clear History button with confirmation - PR karpathy#128: Tournament-style pairwise ranking (Condorcet voting) Tier 3 (Nice-to-Have, More Complex): - PR karpathy#109: Multi-message conversation support with context - PR #24: Test suite infrastructure (pytest setup) New files: - backend/context.py: Smart conversation context management - frontend/src/utils.js: getModelDisplayName helper - frontend/src/components/CopyButton.jsx: Reusable copy button - tests/: Unit test infrastructure - pytest.ini, conftest.py: Test configuration
eddiefleurent
added a commit
to eddiefleurent/llm-council
that referenced
this pull request
Jan 30, 2026
…opy, tests) (#1) * Integrate valuable PRs from abandoned upstream Tier 1 (High Value, Low Risk): - PR #72: Use CHAIRMAN_MODEL for title generation (configurable) - PR #51: Validate OPENROUTER_API_KEY at startup (fail fast) - PR #5: Fix text overflow on chat interface (CSS fixes) - PR #69: Prevent conversation switching while streaming - PR karpathy#110: Copy functionality (copy buttons for responses) Tier 2 (Good Features, Moderate Complexity): - PR karpathy#126: Fix model.split error when model is array (defensive) - PR karpathy#127: Structured error propagation for API failures - PR #67: Continuous conversation mode + prevent empty convos - PR #90: Clear History button with confirmation - PR karpathy#128: Tournament-style pairwise ranking (Condorcet voting) Tier 3 (Nice-to-Have, More Complex): - PR karpathy#109: Multi-message conversation support with context - PR #24: Test suite infrastructure (pytest setup) New files: - backend/context.py: Smart conversation context management - frontend/src/utils.js: getModelDisplayName helper - frontend/src/components/CopyButton.jsx: Reusable copy button - tests/: Unit test infrastructure - pytest.ini, conftest.py: Test configuration * Enhance backend and frontend functionality - Added defensive check in `run_full_council` to handle empty messages. - Improved error handling in `send_message_stream` with logging and sanitized error messages. - Updated `delete_all_conversations` to return a list of deletion results, including any failures. - Modified API call in frontend to require confirmation for deleting conversations. - Enhanced `getModelDisplayName` to handle multi-slash identifiers. - Updated `CopyButton` component to clear timeout on unmount and improve success state handling. - CSS adjustments for better styling and functionality across components. - Added unit tests for conversation retrieval and management functions. * Refactor tournament ranking calculation and enhance frontend message handling - Updated `calculate_tournament_rankings` to use actual matchups for win percentage calculation. - Integrated `calculate_tournament_rankings` into the message streaming process in `send_message_stream`. - Improved loading state management for message updates in the frontend, ensuring immutability and clarity in state changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #117 - Frontend crashes when
modelis an array instead of a string.Problem
The frontend code calls
model.split('/')but some API responses returnmodelas an array (e.g.,["openai/gpt-4o"]) instead of a string, causing:Solution
Added
getModelDisplayName()helper infrontend/src/utils.jsthat handles:Updated Stage1, Stage2, and Stage3 components to use this helper.
Validation
Test plan
🤖 Generated with Claude Code