Windows _fseeki64 _ftelli64 bug fix to load LLaMA2 7B >4GB weight #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ gcc -v Target: x86_64-w64-mingw32 Thread model: posix Supported LTO compression algorithms: zlib zstd gcc version 13.2.0 (Rev6, Built by MSYS2 project)
|
Second commit reverts the first and the third fixes it more cleanly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, large file support in Windows is borked for master branch. This is the minimum change to get LLaMA 7B (26GB) to run in Windows. For files over 4GB, we need to use a different set of API to replace POSIX fseek and ftell.
$ gcc -v
Target: x86_64-w64-mingw32
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.2.0 (Rev6, Built by MSYS2 project)