feat(train): add preflight run guardrails and setup failure hints#343
Open
kaizen-38 wants to merge 1 commit intokarpathy:masterfrom
Open
feat(train): add preflight run guardrails and setup failure hints#343kaizen-38 wants to merge 1 commit intokarpathy:masterfrom
kaizen-38 wants to merge 1 commit intokarpathy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a small reproducibility/guardrail layer for training runs by introducing explicit preflight checks and clearer failure paths.
What changed
train.pyPRECHECK_FAILoutput with structuredreason/hintfor setup failures.WINDOW_PATTERNvalidityTOTAL_BATCH_SIZE % (DEVICE_BATCH_SIZE * MAX_SEQ_LEN) == 0)RuntimeError) for non-finite/exploding loss.program.mdPRECHECK_FAILas setup issue (not experiment crash).Why
This makes failures easier to diagnose, reduces noisy crash loops caused by setup issues, and improves reproducibility by validating key assumptions up front.