Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement group score calculation #5569

Conversation

ipsum-0320
Copy link
Contributor

What type of PR is this?

/kind api-change

What this PR does / why we need it:
Optimize the scoring mechanism used for distribution constraints. Currently, the score of a region is determined by the highest score of the clusters within the region, which is not reasonable. We need a scoring method that reflects the overall situation of the region.

Which issue(s) this PR fixes:

Special notes for your reviewer:
@whitewindmills

Does this PR introduce a user-facing change?:

`karmada-scheduler`: implement group score calculation instead of take the highest score of clusters

@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 19, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2024
@ipsum-0320 ipsum-0320 force-pushed the feat/Implement-group-score-calculation branch from a714203 to 17a92a9 Compare September 19, 2024 10:27
@ipsum-0320
Copy link
Contributor Author

@whitewindmills it fixed #3314, can you take a look?

@whitewindmills
Copy link
Member

/remove-kind api-change
/kind feature
/ok-to-test
/assign

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. ok-to-test and removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.01%. Comparing base (ef7d528) to head (bb7bf06).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
.../scheduler/core/spreadconstraint/group_clusters.go 98.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5569      +/-   ##
==========================================
- Coverage   34.15%   34.01%   -0.15%     
==========================================
  Files         643      645       +2     
  Lines       44503    44908     +405     
==========================================
+ Hits        15201    15274      +73     
- Misses      28145    28478     +333     
+ Partials     1157     1156       -1     
Flag Coverage Δ
unittests 34.01% <98.33%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from whitewindmills. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ipsum-0320 ipsum-0320 force-pushed the feat/Implement-group-score-calculation branch from 1eefa74 to bb7bf06 Compare September 20, 2024 06:54
@ipsum-0320
Copy link
Contributor Author

@whitewindmills i have solved the lint problem.

@XiShanYongYe-Chang
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants