-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement group score calculation #5569
feat: Implement group score calculation #5569
Conversation
a714203
to
17a92a9
Compare
@whitewindmills it fixed #3314, can you take a look? |
/remove-kind api-change |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5569 +/- ##
==========================================
- Coverage 34.15% 34.01% -0.15%
==========================================
Files 643 645 +2
Lines 44503 44908 +405
==========================================
+ Hits 15201 15274 +73
- Misses 28145 28478 +333
+ Partials 1157 1156 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wangxinghao <[email protected]>
Signed-off-by: wangxinghao <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1eefa74
to
bb7bf06
Compare
@whitewindmills i have solved the lint problem. |
/assign |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Optimize the scoring mechanism used for distribution constraints. Currently, the score of a region is determined by the highest score of the clusters within the region, which is not reasonable. We need a scoring method that reflects the overall situation of the region.
Which issue(s) this PR fixes:
Special notes for your reviewer:
@whitewindmills
Does this PR introduce a user-facing change?: