Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/certs: unit test Certificate Manager and Karmada Store #5559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 16, 2024

Description

In this commit, we introduce unit tests for operator certs package. The test cases include but not limited to:

  • Test private key generation.
  • Test self-signed certificate authority (CA) generation.
  • Verify creation of self-signed certificate and key files within the CA.
  • Include tests for utility functions, such as appending to Subject Alternative Names in SSL/TLS certificates.
  • Add tests for Karmada Store operations related to certificates stored in Kubernetes Secrets:
    • Create
    • Read
    • Update
    • Load

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Dependency
This PR depends on #5560 and #5561.

Does this PR introduce a user-facing change?:

NONE

In this commit, we introduce unit tests for operator `certs` package.
The test cases include but not limited to:

- Test private key generation.
- Test self-signed certificate authority (CA) generation.
- Verify creation of self-signed certificate and key files within the CA.
- Include tests for utility functions, such as appending to Subject Alternative Names in SSL/TLS certificates.
- Add tests for Karmada Store operations related to certificates stored in Kubernetes Secrets:
  - Create
  - Read
  - Update
  - Load

Signed-off-by: Mohamed Awnallah <[email protected]>
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 16, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign calvin0327 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants