-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated --bind-address and --secure-port from karmada-descheduler #5552
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5552 +/- ##
==========================================
- Coverage 34.14% 33.94% -0.21%
==========================================
Files 643 645 +2
Lines 44524 44845 +321
==========================================
+ Hits 15203 15221 +18
- Misses 28165 28467 +302
- Partials 1156 1157 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…eduler Signed-off-by: chaosi-zju <[email protected]>
a7ff6d0
to
6edb9ce
Compare
The default port for metrics serving has also been changed to 8080. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove deprecated --bind-address and --secure-port from karmada-descheduler
Which issue(s) this PR fixes:
Fixes part of #5547
Special notes for your reviewer:
Does this PR introduce a user-facing change?: